search

kubermatic / machine-controller

Apache License 2.0
308 stars 131 forks source link

feat(kubevirt): configure runStrategy #1821

Open oliverbaehler opened 4 months ago

oliverbaehler commented 4 months ago

Hi. more like a question:

Is there a specific reason this is hard-coded to RunOnce for the kubevirt probvider?

RunStrategy: &runStrategyOnce,

There's other strategies available: https://pkg.go.dev/kubevirt.io/api/core/v1#VirtualMachineRunStrategy

I guess it makes sense as default, but consider this: If a kubevirt host dives (restarts) all the kubermatic VMIs do not restart (unless you live-migrate to another host, if there's another available). Would it be possible to make this field configurable via machineTemplate? The default can still be RunOnce, but eg. in our use-case we would prefer to use RerunOnFailure

kubermatic-bot commented 1 month ago

Issues go stale after 90d of inactivity. After a furter 30 days, they will turn rotten. Mark the issue as fresh with /remove-lifecycle stale.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubermatic-bot commented 3 weeks ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten