search

kubermatic / machine-controller

Apache License 2.0
308 stars 131 forks source link

Add sig-cluster-management as code owners #1850

Closed ahmedwaleedmalik closed 2 months ago

ahmedwaleedmalik commented 3 months ago

What this PR does / why we need it: Officially adding @kubermatic/sig-cluster-management as the code owner for machine-controller. We are retaining the machine-controller-maintainers section since there is a possibility that someone who doesn't belong to sig-cluster-management might still be a maintainer of MC as this project is a bit more open and can overlap with multiple SIGs. For example, sig-networking through https://github.com/kubermatic/machine-controller/pull/1849, which makes total sense to me.

UPDATE: After review, this PR simply removes the machine-controller-maintainers and adds Navid to sig-cluster-management

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer: I'm not adding or removing anyone who was already added as OWNER. I'm just adding sig-cluster-management there as the owners will be synced automatically then.

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE
ahmedwaleedmalik commented 2 months ago

/approve

kubermatic-bot commented 2 months ago

LGTM label has been added.

Git tree hash: 86c8ea8c4972bc2b3f32aa1f3475771d9dd81d1d

kubermatic-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, cnvergence

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/machine-controller/blob/main/OWNERS)~~ [ahmedwaleedmalik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment