search

kubermatic / machine-controller

Apache License 2.0
308 stars 131 forks source link

Add static up support for KubeVirt in KubeOVN #1851

Closed moadqassem closed 3 months ago

moadqassem commented 3 months ago

What this PR does / why we need it: Enabling the live migration of KubeVirt VMs by default. This would enable us to get a static ip address when using KubeOVN as a CNI. Another PR would actually fine tune this feature based on machine deployment configs.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this? /kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

allow live migration by default

Documentation:

None
yaa110 commented 3 months ago

/approve

kubermatic-bot commented 3 months ago

@moadqassem: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-kubevirt 82d7d00a17b0e8a6a8192b1f001c9d47ff242345 link true /test pull-machine-controller-e2e-kubevirt

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
yaa110 commented 3 months ago

/approve

yaa110 commented 3 months ago

/lgtm

kubermatic-bot commented 3 months ago

LGTM label has been added.

Git tree hash: 72904c7bd4f154d2069011716964f8628f952b8b

yaa110 commented 3 months ago

/approve

yaa110 commented 3 months ago

/lgtm

kubermatic-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaa110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/machine-controller/blob/main/OWNERS)~~ [yaa110] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-bot commented 3 months ago

LGTM label has been added.

Git tree hash: c3dba416b5754e61ca578dd06833db4eac2f3476