search

kubermatic / machine-controller

Apache License 2.0
309 stars 131 forks source link

Remove Pod Network from a VM #1854

Closed moadqassem closed 2 months ago

moadqassem commented 3 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Documentation:

kubermatic-bot commented 3 months ago

@moadqassem: Adding the "do-not-merge/docs-needed" label because no documentation block was detected, please follow our documentation process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubermatic-bot commented 3 months ago

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubermatic-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from moadqassem. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubermatic/machine-controller/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-bot commented 3 months ago

@moadqassem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-test 6cbf8d49a8b57a7bf451304d6b3ffae2c012da0f link true /test pull-machine-controller-test
pull-machine-controller-lint 6cbf8d49a8b57a7bf451304d6b3ffae2c012da0f link true /test pull-machine-controller-lint

Full PR test history

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cnvergence commented 3 months ago

I see this config was added after an issue: https://github.com/kubermatic/machine-controller/issues/1202

moadqassem commented 3 months ago

/hold

cnvergence commented 3 months ago

I would suggest removing this randomized MAC address first and keep the bridge network interface for now. As a follow-up, we can proceed with sorting out if we need to manage different types of interfaces in the KV VMs.

moadqassem commented 2 months ago

This PR is not needed for now as this needs to be investigated further.