search

kubermatic / machine-controller

Apache License 2.0
308 stars 131 forks source link

Support Ubuntu 24.04 #1858

Closed moadqassem closed 1 month ago

moadqassem commented 2 months ago

What this PR does / why we need it: Add support for Ubuntu 24.04 in providers:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this? /kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

support ubuntu 24.04 nobel

Documentation:

none
xmudrii commented 1 month ago

/test all

xmudrii commented 1 month ago

/test pull-machine-controller-e2e-hetzner

xmudrii commented 1 month ago

/test pull-machine-controller-e2e-hetzner

ahmedwaleedmalik commented 1 month ago

/retest

xrstf commented 1 month ago

/override pull-machine-controller-e2e-azure

unrelated RHEL failure

kubermatic-bot commented 1 month ago

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure

In response to [this](https://github.com/kubermatic/machine-controller/pull/1858#issuecomment-2405695105): >/override pull-machine-controller-e2e-azure > >unrelated RHEL failure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
xrstf commented 1 month ago

/approve /lgtm

kubermatic-bot commented 1 month ago

LGTM label has been added.

Git tree hash: eb7a7a8015fda0e4a206b8d69b2e656135878ea4

kubermatic-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/machine-controller/blob/main/OWNERS)~~ [xrstf] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
xrstf commented 1 month ago

/override pull-machine-controller-e2e-azure

kubermatic-bot commented 1 month ago

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure

In response to [this](https://github.com/kubermatic/machine-controller/pull/1858#issuecomment-2410617715): >/override pull-machine-controller-e2e-azure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
xrstf commented 1 week ago

/test pull-machine-controller-e2e-hetzner