kubermatic / machine-controller

Apache License 2.0
308 stars 131 forks source link

Support topology aware zones and regions in KubeVirt #1860

Closed moadqassem closed 2 months ago

moadqassem commented 2 months ago

What this PR does / why we need it: Support for the two labels topology.kubernetes.io/region and topology.kubernetes.io/zone labels where they can deployed on both Node level(The kubelet or the external cloud-controller-manager populates this with the information from the cloud provider) and on PVC level(topology-aware volume provisioners will automatically set node affinity constraints on a PersistentVolume.).

A zone represents a logical failure domain. It is common for Kubernetes clusters to span multiple zones for increased availability and a region represents a larger domain, made up of one or more zones.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this? /kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

region and zone aware labels support

Documentation:

None
yaa110 commented 2 months ago

/approve

kubermatic-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaa110

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/machine-controller/blob/main/OWNERS)~~ [yaa110] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yaa110 commented 2 months ago

/lgtm

kubermatic-bot commented 2 months ago

LGTM label has been added.

Git tree hash: 5cc0934c2a81c1b586c4c7d7fd737135a35b30cd