search

kubermatic / mla

MLA (Monitoring, logging, alerting) solution for KKP.
Apache License 2.0
8 stars 10 forks source link

Revert cortex runtime config changes #109

Closed rastislavs closed 2 years ago

rastislavs commented 2 years ago

Unfortunately, it is not possible to use Cortex runtime-config from the Cortex helm chart without changing the KKP controller code, as the config file name is part of the KKP code (https://github.com/kubermatic/kubermatic/blob/1b8eb244d2ad73f1617a933a6317b227ca58e562/pkg/controller/seed-controller-manager/mla/ratelimit_cortex_controller.go#L46). Thus in order to keep compatibility with KKP 2.18 & 2.19, we need to keep it as it was for now.

We can make this change both in MLA and KKP repos in the release for KKP 2.20.

kubermatic-bot commented 2 years ago

LGTM label has been added.

Git tree hash: e4a96cf5299cc9585a49e506af2710ac4199546b

kubermatic-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, rastislavs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/mla/blob/main/OWNERS)~~ [rastislavs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment