search

kubermatic / mla

MLA (Monitoring, logging, alerting) solution for KKP.
Apache License 2.0
8 stars 9 forks source link

fix yq version check #154

Closed toschneck closed 3 weeks ago

toschneck commented 1 year ago

What this PR does / why we need it: At my mac, the yq --version output is not matching the grep pattern.

yq --version
yq (https://github.com/mikefarah/yq/) version v4.30.8

Which issue(s) this PR fixes:

Fixes #

What type of PR is this? /kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

fix yq 4 version check

Documentation:

NONE
kubermatic-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: toschneck Once this PR has been reviewed and has the lgtm label, please assign rastislavs for approval by writing /assign @rastislavs in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubermatic/mla/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
toschneck commented 1 year ago

/assign @wurbanski

toschneck commented 3 weeks ago

not needed as mla is now installed via insaller