search

kubermatic / mla

MLA (Monitoring, logging, alerting) solution for KKP.
Apache License 2.0
8 stars 9 forks source link

master/seed mla stack requires port numberts for scraping #57

Closed wurbanski closed 3 years ago

wurbanski commented 3 years ago

This changes the annotations to use port number, so that prometheus can scrape the targets.

This means that port number has to be managed in multiple places, unfortunately, but this is a temporary solution.

rastislavs commented 3 years ago

/lgtm /approve

kubermatic-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rastislavs, wurbanski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/mla/blob/main/OWNERS)~~ [rastislavs] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-bot commented 3 years ago

LGTM label has been added.

Git tree hash: 7af453ebcc001e6b3069df5eba71c77fa2846447

aborilov commented 3 years ago

/lgtm

jiachengxu commented 3 years ago

/hold

wurbanski commented 3 years ago

This is already overriden in config/cortex/values.yaml