search

kubermatic / mla

MLA (Monitoring, logging, alerting) solution for KKP.
Apache License 2.0
8 stars 9 forks source link

Changes to the dashboards to tune them to work correctly #64

Closed dharapvj closed 2 years ago

kubermatic-bot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dharapvj To complete the pull request process, please assign jiachengxu after the PR has been reviewed. You can assign the PR to them by writing /assign @jiachengxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubermatic/mla/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rastislavs commented 3 years ago

Wow, this seems to be a quite dramatic change. Could you elaborate on why this was needed? In or dev setup, these dashboards are working fine even without these changes.

Also, the kkp-kubernetes.yaml dashboards are just a copy of KKP upstream dashboards from here with few modifications made by this script. In this case, if this change was really needed, shouldn't the change be made also in https://github.com/kubermatic/kubermatic/tree/master/charts/monitoring/grafana/dashboards/kubernetes ?

jiachengxu commented 2 years ago

@dharapvj Any update on this?