search

kubermatic / mla

MLA (Monitoring, logging, alerting) solution for KKP.
Apache License 2.0
8 stars 10 forks source link

Configure Cortex to accept HA samples #65

Closed SimonTheLeg closed 2 years ago

SimonTheLeg commented 2 years ago

Configure Cortex to accept HA samples from Prometheus (https://cortexmetrics.io/docs/guides/ha-pair-handling/#server-side). Pre-requisite for https://github.com/kubermatic/kubermatic/issues/7207

Has been tested on dev:

Before this PR: We can see that each prometheus replica is considered as a separate stream. image

After Cortex correctly strips the replica label off and only ingests values from one of the Prometheus instances. This can be seen by the number of streams, which is now only half of what it was before. image

The HA-Prometheus that was used for this test can be found in this PR: https://github.com/kubermatic/kubermatic/pull/8189. It makes sense to merge both of them together.

kubermatic-bot commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

kubermatic-bot commented 2 years ago

LGTM label has been added.

Git tree hash: 237671d877fa116627b3b76239ce5edbd5e0bb5f

kubermatic-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiachengxu, SimonTheLeg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/mla/blob/main/OWNERS)~~ [jiachengxu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment