search

kubermatic / terraform-provider-kubermatic

Terraform Kubermatic provider
Apache License 2.0
6 stars 19 forks source link

Implement OpenStack cluster CRUD + cluster version upgrades #11

Closed furkhat closed 4 years ago

furkhat commented 4 years ago

/assign @mfranczy

mfranczy commented 4 years ago

@furkhat this looks good to me, just one minor thing, could you squeeze to a few commits with highlights what have been done? Thanks.

kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
furkhat commented 4 years ago

Done. Can you reopen PR and change mergin compare branch to openstack-cluster? I don't have edit access @maciaszczykm

furkhat commented 4 years ago

/reopen

kubermatic-bot commented 4 years ago

@furkhat: Failed to re-open PR: state cannot be changed. There are no new commits on the furkhat:master branch.

In response to [this](https://github.com/kubermatic/terraform-provider-kubermatic/pull/11#issuecomment-634700723): >/reopen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.