search

kubermatic / terraform-provider-kubermatic

Terraform Kubermatic provider
Apache License 2.0
6 stars 20 forks source link

Azure cloud provider + Openstack NodeDeployments + Project users #15

Closed furkhat closed 4 years ago

furkhat commented 4 years ago

/assign @thetechnick

mfranczy commented 4 years ago

/assign @zreigz

furkhat commented 4 years ago

Added service account resource, token resource and aws acceptance tests

zreigz commented 4 years ago

Please fix compilation error:

kubermatic/resource_node_deployment.go:239:66: undefined: nID
kubermatic/resource_node_deployment.go:256:91: undefined: nID
zreigz commented 4 years ago

@furkhat azure works fine :+1:

kubermatic-bot commented 4 years ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

:memo: Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
zreigz commented 4 years ago

@furkhat I had to specify OpenStack credentials manually. Is there any reason why we can't use predefined credentials?

zreigz commented 4 years ago

Rest things look good

furkhat commented 4 years ago

@furkhat I had to specify OpenStack credentials manually. Is there any reason why we can't use predefined credentials?

I think I did it because explicitly setting values are simpler for design. It could be improved for UX, some other providers (aws) have options to read fields from env if it was not specified explicitly. This enhancement can be added later.

zreigz commented 4 years ago

/lgtm /approve

zreigz commented 4 years ago

/lgtm /approve

kubermatic-bot commented 4 years ago

LGTM label has been added.

Git tree hash: 393cb4b5a3430d8be303eb364ebd5c2e64e6cd5a

kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkhat, zreigz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/terraform-provider-kubermatic/blob/master/OWNERS)~~ [zreigz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment