search

kubermatic / terraform-provider-kubermatic

Terraform Kubermatic provider
Apache License 2.0
6 stars 20 forks source link

Aws credentials #7

Closed mfranczy closed 3 years ago

kubermatic-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubermatic/terraform-provider-kubermatic/blob/master/OWNERS)~~ [mfranczy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubermatic-bot commented 4 years ago

@furkhat: changing LGTM is restricted to collaborators

In response to [this](https://github.com/kubermatic/terraform-provider-kubermatic/pull/7#pullrequestreview-414416904): > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
kubermatic-bot commented 4 years ago

@mfranczy: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
zreigz commented 4 years ago

LGTM, please resolve conflict

mfranczy commented 3 years ago

I am closing this PR in favor of https://github.com/kubermatic/terraform-provider-kubermatic/pull/12