search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
146 stars 46 forks source link

[Configuration]Support bearer tokens in cluster #10

Closed ityuhui closed 4 years ago

ityuhui commented 4 years ago

Load bearer tokens and CA file inside cluster.

/cc @brendandburns

brendandburns commented 4 years ago

Thanks for doing this PR, I added some comments.

ityuhui commented 4 years ago

Thank you @brendandburns

I have updated the code.

brendandburns commented 4 years ago

Sorry one more comment on secure_getenv vs getenv then I think this is ready to merge.

ityuhui commented 4 years ago

Thank you @brendandburns ! The code is updated.

brendandburns commented 4 years ago

/lgtm /approve

--brendan

From: Hui Yu notifications@github.com Sent: Wednesday, April 15, 2020 5:01:08 AM To: kubernetes-client/c c@noreply.github.com Cc: Brendan Burns bburns@microsoft.com; Mention mention@noreply.github.com Subject: Re: [kubernetes-client/c] [Configuration]Support bearer tokens in cluster (#10)

Thank you @brendandburnshttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbrendandburns&data=02%7C01%7Cbburns%40microsoft.com%7Ce8ab45f745d54d0ac23608d7e134af50%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637225488705966220&sdata=BymhAPxcOT1J17IHIMirM%2F%2BkUglhfWL%2B6M8hhHbqrIA%3D&reserved=0 ! The code is updated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkubernetes-client%2Fc%2Fpull%2F10%23issuecomment-613995065&data=02%7C01%7Cbburns%40microsoft.com%7Ce8ab45f745d54d0ac23608d7e134af50%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637225488705976174&sdata=8A383gQdteYk%2BDYu0ES%2BKnTkVRCfI4T84OiNTLT9h1w%3D&reserved=0, or unsubscribehttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABL4HARXPLDRP2UQUNKDOVTRMWOYJANCNFSM4MF3ZLLA&data=02%7C01%7Cbburns%40microsoft.com%7Ce8ab45f745d54d0ac23608d7e134af50%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637225488705976174&sdata=cypeiX%2FW7eWWR1T7BbSCO8IWxJIxp8p%2Bywzy2zupU8U%3D&reserved=0.

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment