Closed katepangLiu closed 2 years ago
Welcome @katepangLiu!
It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/c has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Thanks for submitting the PR!
I'm OK with this change.
But this file is actually generated from https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/C-libcurl/CMakeLists.txt.mustache Can you please submit this change to that repo first ? Take this PR as a reference.
Unknown CLA label state. Rechecking for CLA labels.
Send feedback to sig-contributor-experience at kubernetes/community.
/check-cla /easycla
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, katepangLiu
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hi @brendandburns
This PR shouldn't be merged here manually. The author should submit this PR to openapi-generator first.
@katepangLiu You should submit the chanage to openapi-generator, or this file will be overwritten by the next auto-generation.
@katepangLiu You should submit the chanage to openapi-generator, or this file will be overwritten by the next auto-generation.
@ityuhui Ok, I will do that soon.
In some cases, we need to specify
CURL_INCLUDE_DIR
andCURL_LIBRARIES
manually.