search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
146 stars 46 forks source link

[Configuration] Support exec for kubeconfig #12

Closed ityuhui closed 4 years ago

ityuhui commented 4 years ago

support exec for kube config ( https://kubernetes.io/docs/reference/access-authn-authz/authentication/#configuration )

/cc @brendandburns

brendandburns commented 4 years ago

Some comments. We should consider adding valgrind testing to catch memory leaks.

ityuhui commented 4 years ago

Thank you @brendandburns. I have addressed your comments. Thank you for your finding about these memory leaks.

And I also have run valgrind to check memory and logged two issues #13,#15 I will add the valgrind memory check to Github/Actions sometimes later

brendandburns commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment