Closed caesar0301 closed 1 year ago
Welcome @caesar0301!
It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/c has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Thank you for this PR !
Can you update the commit message based on https://github.com/kubernetes-client/c/pull/140#issuecomment-1227000729 (Remove "#" )
And may need to sign the CLA https://github.com/kubernetes-client/c/pull/140#issuecomment-1227000760
Thank you for this PR !
Can you update the commit message based on #140 (comment) (Remove "#" )
And may need to sign the CLA #140 (comment)
They are all resolved.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: caesar0301, ityuhui
The full list of commands accepted by this bot can be found here.
The pull request process is described here
The committers listed above are authorized under a signed CLA.