kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
141 stars 45 forks source link

Add check for the presence of secure_getenv #163

Closed irozzo-1A closed 1 year ago

irozzo-1A commented 1 year ago

This change introduces support for glibc versions older than 2.17 where secure_getenv was introduced.

k8s-ci-robot commented 1 year ago

Welcome @irozzo-1A!

It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/c has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

brendandburns commented 1 year ago

This looks good to me. I will wait for @ityuhui to have a look also before we merge.

Thanks for the PR!

ityuhui commented 1 year ago

It's good to me too. But I think there is a small problem in the previous code (even though it has no effect on the functionality):

config.h.in

/* Define to 1 if you have the `strndup' function. */
#cmakedefine HAVE_STRNDUP 1
#cmakedefine HAVE_SECURE_GETENV 1

The code should change to

#cmakedefine HAVE_STRNDUP
#cmakedefine HAVE_SECURE_GETENV

because the HAVE_STRNDUP and HAVE_SECURE_GETENV are determined by kubernetes/ConfigureChecks.cmake

check_function_exists(strndup HAVE_STRNDUP)
check_function_exists(secure_getenv HAVE_SECURE_GETENV)

I'll submit another PR to update it.

ityuhui commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irozzo-1A, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ityuhui commented 1 year ago

Thanks for this PR !