Update config.h.in to be more clear

kubernetes-client / c

Official C client library for Kubernetes

Apache License 2.0

141 stars 45 forks source link

Update config.h.in to be more clear #165

Closed ityuhui closed 1 year ago

ityuhui commented 1 year ago

config.h.in

/* Define to 1 if you have the `strndup' function. */
#cmakedefine HAVE_STRNDUP 1
#cmakedefine HAVE_SECURE_GETENV 1

The comment should be removed and
HAVE_STRNDUP and HAVE_SECURE_GETENV don't need to be cmakedefined to any value because they are defined/undefined by https://github.com/kubernetes-client/c/blob/master/kubernetes/ConfigureChecks.cmake

check_function_exists(strndup HAVE_STRNDUP)
check_function_exists(secure_getenv HAVE_SECURE_GETENV)

ityuhui commented 1 year ago

FYI @ahmedalnuaimi @irozzo-1A

ityuhui commented 1 year ago

The libwebsockets repo https://libwebsockets.org/repo/libwebsockets/ cannot be reached now. I'll try it in a while.

ityuhui commented 1 year ago

The libwebsockets repo is back. All checks now pass.

brendandburns commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment