search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
141 stars 45 forks source link

Correct check for getenv()/secure_getenv() #171

Closed ahmedyarub closed 1 year ago

ahmedyarub commented 1 year ago

I encountered this building for Android. Android doesn't have neither function.

brendandburns commented 1 year ago

Minor comments, and CI is failing.

ahmedyarub commented 1 year ago

Minor comments, and CI is failing.

It's weird because on my machine the tests do pass! I'll keep on investigating...

ahmedyarub commented 1 year ago

I introduced function/symbol tests last year but I have just found that my implementation is wrong although everything was working! This is the correct implementation for checking getenv, secure_getenv, and strndup.

brendandburns commented 1 year ago

This looks good to me. Thanks for the updates.

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment