kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
141 stars 45 forks source link

Fix loading users.user.token from yaml config #182

Closed hirishh closed 1 year ago

hirishh commented 1 year ago

Hello,

The api call via user token is correctly handled in kube_config.c#L387 but the token value was never loaded from the yaml config file. This PR fix this.

Best,

hirishh

linux-foundation-easycla[bot] commented 1 year ago

CLA Signed

The committers listed above are authorized under a signed CLA.

hirishh commented 1 year ago

The build is failing because libwebsockets.org today is down. Maybe you could use the mirrored repo on github here: https://github.com/warmcat/libwebsockets

brendandburns commented 1 year ago

/lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, hirishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ityuhui commented 1 year ago

I'll check libwebsockets.org later to see if it's back and then trigger the Build / build-library-and-examples action.