improve generic list and namespacedlist

[DanyT]

• allow empty apiGroup
• select rest api path based on apiGroup value

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: DanyT (0c3a731fa44c10dde80bafd8c931331b4c2b9760)

[k8s-ci-robot]

Welcome @DanyT!

It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/c has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[DanyT]

a usage like the one bellow will not select the correct rest api path

genericClient = genericClient_create(apiClient, "", "v1", "pods");
char *list = Generic_listNamespaced(genericClient, "default");

a usage like the one below will result in segfault as strdup need non null input

genericClient = genericClient_create(apiClient, NULL, "v1", "pods");
char *list = Generic_listNamespaced(genericClient, "default");

[ityuhui]

/lgtm /approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DanyT, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[ityuhui]

Thank you for fixing this issue !

Do you want to solve the second problem you pointed out?

a usage like the one below will result in segfault as strdup need non null input

I think the following might be a fix:

genericClient_t* genericClient_create(apiClient_t *client, const char *apiGroup, const char* apiVersion, const char* resourcePlural) {
     ...
     result->apiGroup = apiGroup ? strdup(apiGroup) : NULL;
     ...
}

void genericClient_free(genericClient_t* client) {
    if (client->apiGroup) {
        free(client->apiGroup);
    }
    ...
}

[DanyT]

yep. will do another pr soon.