search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
141 stars 45 forks source link

conanfile update for lws openssl3 fix #231

Closed ydcpp closed 2 months ago

ydcpp commented 2 months ago

added with_zlib = "zlib" option for libwebsockets dependency to fix build errors when compiling with openssl 3. it's also the recent fix from lws team: https://github.com/warmcat/libwebsockets/issues/2894#issuecomment-2081174948

removed openssl_shared option as it was a workaround for the problem above, now it's not needed. conan users can still configure this option from their own conanfile.

ityuhui commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ityuhui, ydcpp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment