search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
141 stars 45 forks source link

Use the libwebsockets-dev package provided by the operating system #234

Closed ityuhui closed 2 months ago

ityuhui commented 2 months ago

Prior to the release of Ubuntu 22.04 LTS, the libwebsockets-dev package in the Ubuntu/Debian apt repository was incompatible with the C client library. So we have to build libwebsockets v4.2 from source.

But after the release of Ubuntu 22.04 LTS, we can use the libwebsockets-dev package in apt repo to compile this C client library.

Thanks to @Jeansen @homer6 and @rishithaminol for investigating and pushing.

ityuhui commented 2 months ago

/cc @brendandburns

brendandburns commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment