Open DanyT opened 3 days ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: DanyT Once this PR has been reviewed and has the lgtm label, please assign ityuhui for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Thanks for your PR. I will review it.
Minor comments.
This looks good to me. Thanks for the quick turn around. I'll wait for @ityuhui to take a look though in case there are additional comments.
Thanks @brendandburns
@DanyT Can you please fix the issues reported by the code-static-check and code-sytle-check https://github.com/kubernetes-client/c/actions/runs/9781006686/job/27005098287?pr=242 in your code changes ? (Just update your code changes)
You can run the checks locally with
sh ./code-check/code-static-check.sh ./kubernetes/config/
and
find ./kubernetes/config/ -type f -regextype posix-extended -regex ".*\.(c|h)" -exec sh ./code-check/code-style-check.sh {} \;
@DanyT Could you please write an example that uses your new function so we can add it to the automated tests in case your functions are broken by future code changes. We also have memory leak testing in automated testing.