Closed DanyT closed 4 months ago
Thanks for your PR. I will review it.
Minor comments.
This looks good to me. Thanks for the quick turn around. I'll wait for @ityuhui to take a look though in case there are additional comments.
Thanks @brendandburns
@DanyT Can you please fix the issues reported by the code-static-check and code-sytle-check https://github.com/kubernetes-client/c/actions/runs/9781006686/job/27005098287?pr=242 in your code changes ? (Just update your code changes)
You can run the checks locally with
sh ./code-check/code-static-check.sh ./kubernetes/config/
and
find ./kubernetes/config/ -type f -regextype posix-extended -regex ".*\.(c|h)" -exec sh ./code-check/code-style-check.sh {} \;
@DanyT Could you please write an example that uses your new function so we can add it to the automated tests in case your functions are broken by future code changes. We also have memory leak testing in automated testing.
@ityuhui I have added:
Let me know if there is something that i missed.
@DanyT
It seems that the build failed
cd list_pod_buffer; make test
make[1]: Entering directory '/home/runner/work/c/c/examples/list_pod_buffer'
./list_pod_buffer_bin
Cannot get kubernetes configuration from file.
make[1]: *** [Makefile:11: test] Error 255
make[1]: Leaving directory '/home/runner/work/c/c/examples/list_pod_buffer'
make: *** [Makefile:40: test] Error 2
Error: Process completed with exit code 2.
Interesting... it is not the build itself that fails but at runtime it cannot find/load the kube config file. I will look into it. Is there a special location where the kube config file is delivered in this test environment? @ityuhui
Nothing special, the configuration is located in $HOME/.kube/config
@ityuhui Sorry for the delay. This should fix the issue.
Thank you @DanyT
Can you add your example to the memory leak test ?Sorry for not reminding you earlier.
Done
I have no question about this PR. Thanks to @DanyT for the contribution !
@brendandburns I'm OK with the changes.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, DanyT, ityuhui
The full list of commands accepted by this bot can be found here.
The pull request process is described here