search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
148 stars 47 forks source link

Add replace/create/delete to the generic client. #25

Closed brendandburns closed 4 years ago

brendandburns commented 4 years ago

Builds on #24

ityuhui commented 4 years ago

Thank you @brendandburns

It's great that kubernetes-c/client has a generic client now.

Only a small update:

We'd better integrate the build check of examples/generic to Github/Action in https://github.com/kubernetes-client/c/blob/master/examples/Makefile

all：
    cd generic; make

clean:
    cd generic; make clean
brendandburns commented 4 years ago

Comments addressed, please re-check.

ityuhui commented 4 years ago

/lgtm /approve

Thank you for creating the wonderful generic client !

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment