search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
146 stars 46 forks source link

Support multi-thread #36

Closed ityuhui closed 3 years ago

ityuhui commented 3 years ago

The draft to fix #34

We can talk about the implementation here. And some code changes will commit to openapi-generator project and merge back.

ityuhui commented 3 years ago

/cc @brendandburns

brendandburns commented 3 years ago

This implementation looks fine to me. What are the open questions?

ityuhui commented 3 years ago

Hi @brendandburns

No more question except the code review. I will create the PR for apiClient.{h,c} in openapi-generator as you have agreed to the code change.

brendandburns commented 3 years ago

This looks good to me.

brendandburns commented 3 years ago

/lgtm /approve

ityuhui commented 3 years ago

Updated the code after https://github.com/kubernetes-client/c/pull/37 is merged.

Hi @brendandburns Could you please approve the new code change to trigger k8s-ci-robot to merge this PR ?

brendandburns commented 3 years ago

/lgtm /approve

We may want to add a section documenting how to do multi-threaded programming with the client.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ityuhui commented 3 years ago

We may want to add a section documenting how to do multi-threaded programming with the client.

Yes. I plan to address it:

  1. Add a section in README.md
  2. Add an example