Closed minerba closed 2 years ago
Could you please give any function for example ?
I have a Compile warning in this function
Because of parameters "char *" .
v1_pod_t CoreV1API_readNamespacedPod(apiClient_t apiClient, char name , char _namespace , char * pretty , int exact , int _export )
parameters name, _namespace, pretty are unlikely to be modified.
I suggest that functions that take a parameter "char " are changed to "const char"
The same for other functions in Directory '/kubernetes/api/*'.
Good suggestion! I want to do this before but consider it as low priority. And welcome PR, the change should be done in the openapi-generator project.
Ok. Thank U I will PR to openapi-generator project.
Hi @minerba
Do you have interest to fix this issue ?
The steps:
Update the files in the directory: https://github.com/OpenAPITools/openapi-generator/tree/master/modules/openapi-generator/src/main/resources/C-libcurl
Execute the script in https://github.com/kubernetes-client/gen with the configuration https://github.com/kubernetes-client/c/blob/master/settings to get a generated directory kubernetes
# Execute the command in the directory of repo `OpenAPITools/openapi-generator`
mvn clean package
java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate -i ../c/kubernetes/swagger.json -g c -o ../kubernetes --skip-validate-spec
Copy the files in kubernetes
to overwrite the files in the directory of this repo c/kubernetes/
except CMakeLists.txt
Follow the https://github.com/kubernetes-client/c/blob/master/README.md to build and test
Create a PR to apply to merge.
@minerba
You need submit 2 PR.
Hi @minerba
Are you still working on this ticket ?
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
/remove-lifecycle rotten
@ityuhui sorry Well... How can I apply this command? "/remove-lifecycle rotten"
How can I apply this command? "/remove-lifecycle rotten"
I have done it. You don't need do it again.
@ityuhui Thank you:)
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
I will fix it. Reopen this ticket to trace.
Thanks your Pr.
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closing this issue.
I think functions should receive "const char" rather than "char".
for example name or _namespace are unlikely to be modified.