kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
144 stars 46 forks source link

what is the version of library? #64

Closed clearday4 closed 2 years ago

clearday4 commented 3 years ago

According to the README.md in kubernetes directory The version is mentioned that API version: v1.17.4 Package version: Build package: org.openapitools.codegen.languages.CLibcurlClientCodegen

Is it the right API Version? And there is no ABI version for library?

ityuhui commented 3 years ago

The code is generated according to the kubernetes API swagger v1.17.4

brendandburns commented 3 years ago

We should regenerate the library for a later version of Kubernetes.

ityuhui commented 3 years ago

We should regenerate the library for a later version of Kubernetes.

Which version is better for now ? I see the latest official release is v1.21.1

brendandburns commented 3 years ago

Ultimately, we should generate a new version for every version of Kubernetes, see for example the Java client:

https://github.com/kubernetes-client/java/wiki/2.-Versioning-and-Compatibility

But for now, let's jump forward to 1.21.1

But we should tag the repo with a '0.1' first so that people can check out the code for usage with older Kubernetes.

ityuhui commented 3 years ago

OK. I will do it.

ityuhui commented 3 years ago

I'm working on the websocket/exec support for c client now (maybe delivered in 1 week). It's better to tag after this feature is merged, then users can exec command in pod with the older Kubernetes.

brendandburns commented 3 years ago

ok, works for me.

We should also think about how we could release .deb/.rpm packages

ityuhui commented 3 years ago

We should also think about how we could release .deb/.rpm packages

Agree. then we can integrate them into package managers e.g. apt/yum.

clearday4 commented 3 years ago

Thanks @brendandburns @ityuhui BTW, libkubernestes.so doesn't have an ABI version? And I have little concerned about compatibility with previous versions, how about checking the compatibility with 1.18 or 1.19?

clearday4 commented 3 years ago

I'm working on the websocket/exec support for c client now (maybe delivered in 1 week). It's better to tag after this feature is merged, then users can exec command in pod with the older Kubernetes.

That's a great news!! What websocket library did you select?

brendandburns commented 3 years ago

@clearday4 Kubernetes maintains a n-2 compatability, so a 1.20 library should work with 1.18. It will mostly work with older versions too, but it is less guaranteed.

We will plan to align the versioning of this library with the Kubernetes version, so hopefully going forward you will be able to select a version that works for your version of kubernetes.

ityuhui commented 3 years ago

What websocket library did you select?

It's libwebsockets

ityuhui commented 2 years ago

I will start to work for this task. Firstly, tag current version using below command after https://github.com/kubernetes-client/c/pull/80 is merged:

git tag -a v0.1.0 -m "version 0.1.0"
ityuhui commented 2 years ago

I have tagged the current code as "v0.1.0" https://github.com/kubernetes-client/c/tags

And created a pre-release: https://github.com/kubernetes-client/c/releases/tag/v0.1.0

Next, I will upgrade the swagger version to Kubernetes v1.22.1

ityuhui commented 2 years ago

The C client has bumped forward to Kubernetes v1.22.1 https://github.com/kubernetes-client/c/pull/82

And we also have a "Versioning and Compatibility" doc https://github.com/kubernetes-client/c/blob/master/docs/versioning-and-compatibility.md

I think this issue can be closed. @clearday4

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

ityuhui commented 2 years ago

This problem is resoved.