Closed ityuhui closed 3 years ago
/cc @brendandburns
Thank you @brendandburns I will address these comments one by one.
Hi @brendandburns
Review comments are addressed and replied.
Could you please take a look again ?
Thanks for addressing the comments.
I had one clarification.
Also, I think that the escaping of the chars code is a little complicated, I would suggest that we pre-allocate the entire escaped string and then run through it linearly rather than using strncat
, also I think it needs unit tests, but we can address that in a follow up PR.
If we clean up the unnecessary allocation by changing the ownership of the path
variable, then I'm ok with merging.
Thanks @brendandburns .
I will address the comments after coming back from vacation.
Have a good vacation!
Hi @brendandburns
I have made below changes:
path
in wsclient_t
apiKeys
to the function
wsclient_t *wsclient_create(const char *base_path, sslConfig_t * ssl_config, list_t * apiKeys, int ws_log_mask)
This parameter is not used now, but for in-cluster authentication in future.
Could you please check whether this PR can merge now ? Thanks.
@ityuhui this code looks ok to me, but I'd like to make sure that @clearday4 is ok with it also before we merge.
Thanks!
@ityuhui @brendanburns it is good in first stage. In the next step, It's better to consider the multithread and implement an additional LWS_CALLBACK_CLIENT_APPEND_HANDSHAKE_HEADER callback for incluster_config. Thanks a lot!
/lgtm /approve
We can merge this and take improvements as the next step.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, ityuhui
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thank you for your review @brendandburns @clearday4
websocket and pod exec support for the c client