search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
146 stars 46 forks source link

Merge 2 useful PRs and other changes from OpenAPITools/openapi-generator repo #7

Closed ityuhui closed 4 years ago

ityuhui commented 4 years ago

To implement the configuration for kubernetes-client/c, merge 2 PRs from OpenAPITools/openapi-generator repo:

  1. Support SSL client authentication for the c client (#5719) https://github.com/OpenAPITools/openapi-generator/pull/5719

  2. Fix base64 decode funtion (#5642) https://github.com/OpenAPITools/openapi-generator/pull/5642

/cc @brendandburns

brendandburns commented 4 years ago

This change looks good to me.

Is this a manual patch? Or did you re-run code generation?

ityuhui commented 4 years ago

Hi @brendandburns

Yes, this is a manual patch.

We do not need re-run code generation because there is no difference between manual patch and code generation for the files apiClient.h and apiClient.c.

For others model or api files generated by openapi-generator, there is also no important changes.

But I can re-run code generation too, it does not need big effort. which solution do you prefer ?

brendandburns commented 4 years ago

I'd prefer that we re-run the code generation, I think it is a good practice to never hand-edit the generated files.

Thanks!

ityuhui commented 4 years ago

Sure. I will do it.

And c/kubernetes/README.md which is updated in the PR https://github.com/kubernetes-client/c/pull/5 will not be changed when re-generating.

ityuhui commented 4 years ago

Hi @brendandburns

The code generation is re-run (both build and examples test successfully) and new code change is pushed here. Could you please review the latest change change ?

brendandburns commented 4 years ago

/lgtm /approve

Thanks!

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment