kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
144 stars 46 forks source link

Increase maximum bearer token size to avoid truncation #74

Closed ahmedyarub closed 3 years ago

k8s-ci-robot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 3 years ago

Welcome @ahmedyarub!

It looks like this is your first PR to kubernetes-client/c 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/c has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

ityuhui commented 3 years ago

Thank you @ahmedyarub

Could you please sign the CLA ? or the PR cannot merge.

ahmedyarub commented 3 years ago

Thank you @ahmedyarub

Could you please sign the CLA ? or the PR cannot merge.

I tried many times already but I'm not receiving the email!!

ahmedyarub commented 3 years ago

Signed

ityuhui commented 3 years ago

/lgtm

ityuhui commented 3 years ago

I think this PR can merge. @brendandburns

brendandburns commented 3 years ago

/lgtm /approve

@ityuhui I believe that you can apply /approve also if you want.

ahmedyarub commented 3 years ago

why was this closed without merging?

ahmedyarub commented 3 years ago

@brendanburns is there a reason for closing this PR?

ityuhui commented 3 years ago

Hi @ahmedyarub

Don't worry. Maybe @brendandburns takes this PR as an issue and closes it.

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brendanburns commented 3 years ago

Oops I'm sorry I definitely didn't mean to close this. Apologies!

On Tue, Aug 17, 2021, 7:38 PM Kubernetes Prow Robot < @.***> wrote:

Merged #74 https://github.com/kubernetes-client/c/pull/74 into master.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kubernetes-client/c/pull/74#event-5172192656, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJZQXV5BZGPQOE7ONXVVSLT5MMJZANCNFSM5CHVHAFQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

ahmedyarub commented 3 years ago

it's OK glad we sorted this out. I'll work on the other PR's today