Closed ahmedyarub closed 2 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ahmedyarub
To complete the pull request process, please assign brendandburns after the PR has been reviewed.
You can assign the PR to them by writing /assign @brendandburns
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
@ahmedyarub: PR needs rebase.
Replaced by https://github.com/kubernetes-client/c/pull/80
This should be merged after the other two PRs. The number of changes in fact is small if you merge the other PRs before this one. This includes Windows build support + installation support on all platforms. Everything is tested.