kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
144 stars 46 forks source link

Add examples, and pre and post CMake building scripts #78

Closed ahmedyarub closed 2 years ago

ahmedyarub commented 2 years ago

This replaces https://github.com/kubernetes-client/c/pull/75 and should be tested in combination with https://github.com/OpenAPITools/openapi-generator/pull/10284 and only merged after that PR is merged.

ityuhui commented 2 years ago

Could you please regenerate and commit the kubernetes/CMakeLists.txt in this PR after OpenAPITools/openapi-generator#10284 is merged ?

ityuhui commented 2 years ago

The check Build / build-library-and-examples failed.

https://github.com/kubernetes-client/c/pull/78/checks?check_run_id=3468817370

brendandburns commented 2 years ago

This looks good to me, I defer to @ityuhui for the final LGTM.

ahmedyarub commented 2 years ago

The check Build / build-library-and-examples failed.

https://github.com/kubernetes-client/c/pull/78/checks?check_run_id=3468817370

I fixed the scripts and tested them on Ubuntu but now https://libwebsockets.org/repo/libwebsockets is down. Please rerun the Actions later one the website is back online.

ahmedyarub commented 2 years ago

Everything is working now!

ityuhui commented 2 years ago

Hi @ahmedyarub

The code change is great ! Only one comment for installing "libyaml-dev".

ahmedyarub commented 2 years ago

Changed libyaml version to the latest stable one and updated the readme.

ityuhui commented 2 years ago

I'm OK with the current solution that building yaml from source code.

Trace the issue that "yamlConfig.cmake" should be packaged to "libyaml-dev" at https://github.com/yaml/libyaml/issues/222

I will merge this PR tomorrow if there is no more comments.

ityuhui commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedyarub, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment