Closed ahmedyarub closed 2 years ago
Could you please regenerate and commit the kubernetes/CMakeLists.txt
in this PR after OpenAPITools/openapi-generator#10284
is merged ?
The check Build / build-library-and-examples
failed.
https://github.com/kubernetes-client/c/pull/78/checks?check_run_id=3468817370
This looks good to me, I defer to @ityuhui for the final LGTM.
The check
Build / build-library-and-examples
failed.https://github.com/kubernetes-client/c/pull/78/checks?check_run_id=3468817370
I fixed the scripts and tested them on Ubuntu but now https://libwebsockets.org/repo/libwebsockets is down. Please rerun the Actions later one the website is back online.
Everything is working now!
Hi @ahmedyarub
The code change is great ! Only one comment for installing "libyaml-dev".
Changed libyaml version to the latest stable one and updated the readme.
I'm OK with the current solution that building yaml from source code.
Trace the issue that "yamlConfig.cmake" should be packaged to "libyaml-dev" at https://github.com/yaml/libyaml/issues/222
I will merge this PR tomorrow if there is no more comments.
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ahmedyarub, ityuhui
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This replaces https://github.com/kubernetes-client/c/pull/75 and should be tested in combination with https://github.com/OpenAPITools/openapi-generator/pull/10284 and only merged after that PR is merged.