search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
146 stars 46 forks source link

[Configuration]Support X509 client certificate in kube config file #9

Closed ityuhui closed 4 years ago

ityuhui commented 4 years ago

Load configuration for X.509 client certificate in kube config file (~/.kube/config)

/cc @brendandburns

brendandburns commented 4 years ago

Looks great, I had a few comments.

Thanks!

ityuhui commented 4 years ago

Hi @brendandburns

The code is updated. Could you please review the new code change ?

brendandburns commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ityuhui commented 4 years ago

Thank you @brendandburns