some keywords conflict occurs with zebos

kubernetes-client / c

Official C client library for Kubernetes

Apache License 2.0

144 stars 46 forks source link

some keywords conflict occurs with zebos #90

Closed clearday4 closed 2 years ago

clearday4 commented 2 years ago

If I link the libkubernetes and zebos together, some keywords conflict occurred. list_create, list_free could you change these keywords?

18:04:22,338 INFO  - //MW_LIB/KAS/obj/x86_K8.4/libkubernetes.a(list.c.o): In function `list_create':
18:04:22,338 INFO  - //MW_LIB/KAS/K8SCLIENT_C_3RD/kubernetes/src/list.c:26: multiple definition of `list_create'
18:04:22,338 INFO  - ../../platform/arch-x86_K/obj/lib.a(linklist.o)://NET_APP/ZEBOS/ZEBOS3RD/lib/linklist.c:21: first defined here
18:04:22,338 INFO  - //MW_LIB/KAS/obj/x86_K8.4/libkubernetes.a(list.c.o): In function `list_free':
18:04:22,338 INFO  - //MW_LIB/KAS/K8SCLIENT_C_3RD/kubernetes/src/list.c:92: multiple definition of `list_free'
18:04:22,338 INFO  - ../../platform/arch-x86_K/obj/lib.a(linklist.o)://NET_APP/ZEBOS/ZEBOS3RD/lib/linklist.c:48: first defined here
18:04:22,338 INFO  - collect2: error: ld returned 1 exit status

ityuhui commented 2 years ago

I want to resolve this problem before. OK. will put this issue to development backlog. You can also submit a PR to the upstream project openapi-generatror https://github.com/ityuhui/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/C-libcurl/list.h.mustache Then we can merge the change back.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

ityuhui commented 2 years ago

/remove-lifecycle stale

ityuhui commented 2 years ago

@minerba

Since your PR ( https://github.com/OpenAPITools/openapi-generator/pull/11190 and https://github.com/OpenAPITools/openapi-generator/pull/11677) have already been committed, can you regenerate the c client to merge the change? The guide can be found at https://github.com/kubernetes-client/c/blob/master/docs/how-to-regenerate-the-c-client.md

minerba commented 2 years ago

@ityuhui Ok, I will check

ityuhui commented 2 years ago

@minerba

I merge your code by the PR #109 because I want to fix a bug based on the latest code. So you don't need re-generate the C client any more for this ticket. Thanks !

minerba commented 2 years ago

@ityuhui Ok, Thank you!