search

kubernetes-client / c

Official C client library for Kubernetes
Apache License 2.0
146 stars 45 forks source link

Support "IntOrString" #99

Closed ityuhui closed 2 years ago

ityuhui commented 2 years ago

This PR consists of two parts:

  1. The files generated by kubernetes-client/gen and OpenAPITools/openapi-generator
  2. The model implementation for IntOrString I created manually.
ityuhui commented 2 years ago

/cc @brendandburns

brendandburns commented 2 years ago

One really minor comment, but LGTM in general. Thanks for handling this!

ityuhui commented 2 years ago

Hi @brendandburns

Could you take another look ?

brendandburns commented 2 years ago

/lgtm /approve

k8s-ci-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, ityuhui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/c/blob/master/OWNERS)~~ [brendandburns,ityuhui] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ityuhui commented 2 years ago

Thank you @brendandburns

Happy Holidays !