search

kubernetes-client / csharp

Officially supported dotnet Kubernetes Client library
Apache License 2.0
1.09k stars 294 forks source link

Please add net452 to KubernetesClient NuGet package #239

Closed xinyanmsft closed 5 years ago

xinyanmsft commented 5 years ago

Please include net452 binary in the NuGet package.

Today when I invoke 'dotnet pack' on my machine, the resulting package contains net452. However the downloaded official package does not include it.

This means, when running in a full framework process, things like WebSocket authentication will not work (the issue was fixed in pull request #231, but NuGet package needs to include 452 to make it available).

Thanks!

tg123 commented 5 years ago

I am working with integrating with azure pipeline which will enable windows base targets.

brendandburns commented 5 years ago

Yeah, right now the build step happens in Linux on Travis, that's probably not ideal...

brendandburns commented 5 years ago

Now that the pipeline is checked in, I will create a pipeline to build that artifact...

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

fejta-bot commented 5 years ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle rotten

fejta-bot commented 5 years ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /close

k8s-ci-robot commented 5 years ago

@fejta-bot: Closing this issue.

In response to [this](https://github.com/kubernetes-client/csharp/issues/239#issuecomment-517889267): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >Send feedback to sig-testing, kubernetes/test-infra and/or [fejta](https://github.com/fejta). >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.