search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 148 forks source link

Chore: Migrate java clients from swagger-codegen to openapi-generator #117

Closed yue9944882 closed 4 years ago

yue9944882 commented 5 years ago

/cc @brendandburns

/hold (until 5.0.0 released)

note that this pull will involve some critical dependency changes in the java repo.

brendandburns commented 5 years ago

@yue9944882 the last time I tried this, it broke a bunch of stuff because the Quantity and other type overrides didn't work correctly. Have you tried compiling this in the Java repo? Does it work?

Before we do this switch, I want to see the PR that it generates for the Java repo....

Thanks

yue9944882 commented 5 years ago

@brendandburns i also tried locally but didn't other surprises except for bunch of underlying dependency switching (not sure if it's breaking backward-compatibility). sure i will sent a pull in the repo to reflect the generator changes.

brendandburns commented 5 years ago

To be clear it was the custom mappings like you added in https://github.com/kubernetes-client/gen/pull/118 that broke. So if those continue to work correctly, then this LGTM.

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

davidxia commented 5 years ago

/remove-lifecycle stale

wing328 commented 5 years ago

As discussed over IM, please use the latest stable version v4.1.3 instead as the string's format support together with type mapping is only added in recent versions.

brendandburns commented 4 years ago

@yue9944882 is this up to date? Now that we've merged the code changes in the java repo, I'd like to merge the corresponding generation code.

Thanks!

yue9944882 commented 4 years ago

yes, this is in ready state

yue9944882 commented 4 years ago

/hold cancel

@brendandburns for merging

brendandburns commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment