search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

Bugfix: Preserve field manager types for java client #123

Closed yue9944882 closed 5 years ago

yue9944882 commented 5 years ago

/cc @brendandburns

a new type v1.Fields are introduced into ObjectMeta, we should preserve it or the generated type will be lang.Object

https://github.com/kubernetes-client/java/blob/dc82549dde1eeea7593203dec788af0fe33685a7/kubernetes/src/main/java/io/kubernetes/client/models/V1ManagedFieldsEntry.java#L37

yue9944882 commented 5 years ago

/kind bug

brendandburns commented 5 years ago

/lgtm /approve

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment