search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 148 forks source link

Refactor: use provided value for dates haskell #128

Closed frincon closed 5 years ago

frincon commented 5 years ago

This reverts the previous PR: https://github.com/kubernetes-client/gen/pull/127 Instead of using sed, it is using a custom parameter provided from the openapi generator.

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: frincon To complete the pull request process, please assign brendandburns You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
frincon commented 5 years ago

Do not merge, openapi-generator have a bug:

frincon commented 5 years ago

Closing, as there are other bug in openapi.