kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 148 forks source link

Add continue and limit to custom objects spec #130

Closed scottilee closed 5 years ago

scottilee commented 5 years ago

Adds continue and limit parameters to the custom objects specification.

Fixes https://github.com/kubernetes-client/python/issues/965.

k8s-ci-robot commented 5 years ago

Welcome @scottilee!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

scottilee commented 5 years ago

/assign @roycaihw

brendandburns commented 5 years ago

LGTM, @roycaihw any final comments before we merge?

roycaihw commented 5 years ago

/lgtm /approve

Thanks

yue9944882 commented 5 years ago

/lgtm

k8s-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: roycaihw, scottilee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
roycaihw commented 5 years ago

Manually tagged based on the consensus in the thread.