search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

Fixes the wrong link auto-generation in the python generator #134

Closed palnabarun closed 4 years ago

palnabarun commented 4 years ago

The change in this PR makes sure that all instances of kubernetes-kubernetes.client are replaced by kubernetes-client.

Brief Background

https://github.com/kubernetes-client/gen/blob/f14e0bb9de84a09644890a111f0c101759471bb0/openapi/python.sh#L57

The above line replaces all instances of client with kubernetes.client which has the side effect of changing pip install git+https://github.com/kubernetes-client/python.git to pip install git+https://github.com/kubernetes-kubernetes.client/python.git.

References

Fixes #133

k8s-ci-robot commented 4 years ago

Welcome @palnabarun!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

palnabarun commented 4 years ago

/cc @roycaihw

palnabarun commented 4 years ago

/assign

roycaihw commented 4 years ago

/cc

roycaihw commented 4 years ago

/lgtm /approve

palnabarun commented 4 years ago

/assign @brendandburns

brendandburns commented 4 years ago

/approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, palnabarun, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
palnabarun commented 4 years ago

Thank you @roycaihw @brendanburns for the approvals. :)