search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 148 forks source link

Make custom object spec's delete body optional #142

Closed yue9944882 closed 4 years ago

yue9944882 commented 4 years ago

the "body" of delete API is actually optional. if the body is absent on delete call, kube-apiserver will be acquiring corresponding delete options from HTTP query parameters.

brendandburns commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment