search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

feat: switch python-asyncio to use openapi-generator v4.2.3 #146

Closed tomplus closed 4 years ago

tomplus commented 4 years ago

As a default we use openapi-generator v3.3.4 which was released in 2018. In this PR I switch python-asyncio to the latest version of generator v4.2.3. I don't want to switch it globally because their changelog is very impressive with some breaking changes too. I encourage other maintainers to evaluate the upgrade before we switch it globally.

The new openapi-generator's schema validator can't work with our pre-processed schema so it has to be disabled (more info #145).

Thank you.

cc: @brendandburns @roycaihw

brendandburns commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, tomplus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment