search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 146 forks source link

Disable selinux checks for the client-generating container #147

Closed fabianvf closed 4 years ago

fabianvf commented 4 years ago

When running client generation with selinux running, the generator won't have proper access to the /output_dir volume due to selinux checks. Adding the --security-opt label:disable will disable the selinux checks and allow client generation to succeed.

brendandburns commented 4 years ago

Based on this doc:

https://docs.docker.com/engine/reference/run/#security-configuration

I think it should be label=disable

fabianvf commented 4 years ago

Good catch, looks like the label:disable syntax works in docker but label=disable works with both docker + podman and is the documented option. Strangely most examples on the internet seem to use the : syntax, must be from an old blog post or something.

brendandburns commented 4 years ago

/lgtm /approve

k8s-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, fabianvf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment