Closed d-cs closed 4 years ago
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.
It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Welcome @d-cs!
It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-client/gen has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
CLA Signed - Triggering Re-check
Output of the generator can be seen here: https://github.com/little-wolf-studio/client-jquery/tree/master/src/gen
Thanks, this is great to have. Do you have any ideas about how we might want to package this into the https://github.com/kubernetes-client/javascript repository?
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brendandburns, d-cs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@brendandburns Thank you! I'm working on the closer integration now, once I've got some thoughts together I'll drop them in the SIG Slack channel.
I need a Kubernetes client that can work in the browser, rather than NodeJS.
I tested these as alternative generators:
typescript-axios
The generated code has naming conflicts for instance,AutoscalingV2beta1
andAutoscalingV2beta2
would export objects with the same name, causing the TypeScript compiler to error.typescript-fetch
As with AxiosIn the end I stuck with
typescript-jquery
noting that on the NodeJS client that there is a plan to make a jQuery version. I believe this generator forms the start of that work.I used these settings to test the generation process Gist.