search

kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 145 forks source link

Switch to JDK date time library #177

Closed dsyer closed 3 years ago

dsyer commented 3 years ago

Please do not merge until we finish discussing in the Java client tracker.

See https://github.com/kubernetes-client/java/issues/1411

k8s-ci-robot commented 3 years ago

Welcome @dsyer!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

dsyer commented 3 years ago

This can (and should) be merged now that the Java client is using JDK time on master: https://github.com/kubernetes-client/java/pull/1418

brendandburns commented 3 years ago

/lgtm /approve

k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, dsyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)~~ [brendandburns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
synox commented 3 years ago

The pom of release 11.0.0 still contains joda-time, see https://search.maven.org/artifact/io.kubernetes/client-java-api/11.0.0/bundle

dsyer commented 3 years ago

11.0.0 was released before this change. 12.0.0 will be the first release with JDK time I think. But I suppose that means you can't use the generator from master for a project that depends on 11.0.x? I don't know how to solve that - you probably have to use a tag or a fixed commit ID for the generator.