kubernetes-client / gen

Common generator scripts for all client libraries
Apache License 2.0
148 stars 145 forks source link

Fix for issue #181 - use host networking on container #182

Closed karunasagark closed 3 years ago

karunasagark commented 3 years ago

An approach to fix issue #181 is to use host networking on the container run by client-generator.sh. With this change was able to generate the models as suggested by [here](https://github.com/kubernetes-client/java/blob/master/docs/generate-model-from-third-party-resources.md

k8s-ci-robot commented 3 years ago

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
k8s-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karunasagark To complete the pull request process, please assign brendandburns after the PR has been reviewed. You can assign the PR to them by writing /assign @brendandburns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-client/gen/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 years ago

Welcome @karunasagark!

It looks like this is your first PR to kubernetes-client/gen 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/gen has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

karunasagark commented 3 years ago

/check-cla

brendandburns commented 3 years ago

I don't think this is a good fix. There is something wrong with your container networking setup, this works fine on my machine, I would check your container/docker networking. Does it work for other containers?

yue9944882 commented 3 years ago

I would check your container/docker networking. Does it work for other containers?

+1. what do you get running docker network ls?

karunasagark commented 3 years ago

Thanks @brendanburns and @yue9944882. Saw host network enabled in the instructions so assumed that would need the same. I realized that host networking is needed here to interact with the kind cluster.

You are right. Something wrong with my docker daemon. Reinstalling it fixed the issue. Closing this PR and issue #181 accordingly.